Onboarding Intake(1/3): Intake Runner#1086
Onboarding Intake(1/3): Intake Runner#1086devanshcache wants to merge 38 commits intostackitcloud:mainfrom
Conversation
devanshcache
changed the title
yago-123
force-pushed
the
onboard-intake
branch
from
89b2fc8 to
540b360
Compare
|
@yago-123 could you please resolve the comments you adressed already? I will only start with another review as soon as all open comments are resolved. |
|
And please check that failing CI pipeline. Maybe run a |
Yes! notice this is still in progress though |
yago-123
force-pushed
the
onboard-intake
branch
3 times, most recently
from
9d5b54d to
3922287
Compare
|
This should be ready for review whenever you have time. Just pushed the new SDK with the hostname region-free. CC @rubenhoenle |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
| Description: descriptions["labels"], | ||
| ElementType: types.StringType, | ||
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
In this case, if I remove the Computed: true it retrieves the following error:
2026-03-31T17:01:18.527+0200 [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccIntakeRunnerMin test_terraform_path=/opt/homebrew/bin/terraform test_working_directory=/var/folders/4x/5xl9kvgx4d33r3xjbqd05mw80000gn/T/plugintest2512537327 test_step_number=1
error=
| Error running apply: exit status 1
|
| Error: Provider produced inconsistent result after apply
|
| When applying changes to stackit_intake_runner.example, provider
| "provider[\"registry.terraform.io/hashicorp/stackit\"]" produced an
| unexpected new value: .labels: was null, but now cty.MapValEmpty(cty.String).
|
| This is a bug in the provider, which should be reported in the provider's own
| issue tracker.
resource_acc_test.go:62: Step 1/4 error: Error running apply: exit status 1
Error: Provider produced inconsistent result after apply
When applying changes to stackit_intake_runner.example, provider
"provider[\"registry.terraform.io/hashicorp/stackit\"]" produced an
unexpected new value: .labels: was null, but now cty.MapValEmpty(cty.String).
This is a bug in the provider, which should be reported in the provider's own
issue tracker.
To me this looks like we default to null, but the labels later are retrieved as {} making a difference after the apply (notice this only happens for min test).
An alternative to this would be to modify the mapFields to cover this case...
There was a problem hiding this comment.
yes, cover it in mapFields please
| intakeUtils "github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/intake/utils" | ||
| "github.com/stackitcloud/terraform-provider-stackit/stackit/internal/validate" | ||
|
|
||
| "github.com/stackitcloud/stackit-sdk-go/services/intake" |
There was a problem hiding this comment.
| "github.com/stackitcloud/stackit-sdk-go/services/intake" | |
| intake "github.com/stackitcloud/stackit-sdk-go/services/intake/v1betaapi" |
Please use the new SDK structure so we don't introduce new tech-debt here: stackitcloud/stackit-sdk-go#5062
There was a problem hiding this comment.
Applies to the whole implementation. Ping me via DM if you have any further questions 😅
There was a problem hiding this comment.
Adressed, this new approach seems solid👍
…AndLogStateFields
4 participants
Description
This PR onboards the new STACKIT Intake (ticket) service into the Terraform provider.
Intake is composed of three components:
This PR contains the Intake Runners part only to make a quicker and less overwhelming review.
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)